Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762168AbZDALrg (ORCPT ); Wed, 1 Apr 2009 07:47:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756953AbZDALr0 (ORCPT ); Wed, 1 Apr 2009 07:47:26 -0400 Received: from extu-mxob-1.symantec.com ([216.10.194.28]:51171 "EHLO extu-mxob-1.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754871AbZDALrY (ORCPT ); Wed, 1 Apr 2009 07:47:24 -0400 Date: Wed, 1 Apr 2009 12:46:13 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@blonde.anvils To: KOSAKI Motohiro cc: Minchan Kim , linux-mm , lkml , Andrew Morton , Christoph Lameter , Nick Piggin Subject: Re: add_to_swap_cache with GFP_ATOMIC ? In-Reply-To: <20090401165516.B1EB.A69D9226@jp.fujitsu.com> Message-ID: References: <28c262360903310338k20b8eebbncb86baac9b09e54@mail.gmail.com> <20090401165516.B1EB.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 17 On Wed, 1 Apr 2009, KOSAKI Motohiro wrote: > > IOW, GFP_ATOMIC on add_to_swap() was introduced accidentally. the reason > was old add_to_page_cache() didn't have gfp_mask parameter and we didn't > have the reason of changing add_to_swap() behavior. > I think it don't have deeply reason and changing GFP_NOIO > don't cause regression. You may well be right: we'll see if you send in a patch to change it. But I won't be sending in that patch myself, that's all :) Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/