Date: Wed, 1 Apr 2009 14:24:08 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       Steven Rostedt <rostedt@goodmis.org>, fweisbec@gmail.com
Subject: Re: [PATCH] tracing/filters: allow event filters to be set only
	when not tracing
Message-ID: <20090401122408.GG12966@elte.hu>
References: <1238390546.6368.65.camel@bookworm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1238390546.6368.65.camel@bookworm>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 950
Lines: 26


* Tom Zanussi <tzanussi@gmail.com> wrote:

> This patch adds code allowing the event filter to be set only if 
> there's no active tracing going on.

> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -498,6 +498,9 @@ event_filter_write(struct file *filp, const char __user *ubuf, size_t cnt,
>  	struct filter_pred *pred;
>  	int err;
>  
> +	if (tracing_is_enabled() && (!tracer_is_nop() || call->enabled))
> +		return -EBUSY;

hm, but it would be the normal use-case to set filters on the fly. 
To experiment around with them and shape them until the output is 
just right. Having to turn the tracer on/off during that seems quite 
counterproductive to that use-case.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/