Message-ID: <49D36951.9000604@kernel.org>
Date: Wed, 01 Apr 2009 22:17:05 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Thunderbird 2.0.0.19 (X11/20081227)
MIME-Version: 1.0
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
CC: axboe@kernel.dk, bharrosh@panasas.com, linux-kernel@vger.kernel.org,
       tj@kenel.org
Subject: Re: [PATCH 8/8] blk-map: reimplement blk_rq_map_user() using blk_rq_map_user_iov()
References: <49D36329.20004@kernel.org>	<20090401215933S.fujita.tomonori@lab.ntt.co.jp>	<49D3662B.3000801@kernel.org> <20090401221102O.fujita.tomonori@lab.ntt.co.jp>
In-Reply-To: <20090401221102O.fujita.tomonori@lab.ntt.co.jp>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1907
Lines: 48

Hello,

FUJITA Tomonori wrote:
> On Wed, 01 Apr 2009 22:03:39 +0900
> Tejun Heo <tj@kernel.org> wrote:
> 
>> FUJITA Tomonori wrote:
>>> No, we are not talking about blk_rq_append_bio().
>>>
>>> We are talking about the multiple bio handling in blk_rq_map_user,
>>> which is the feature that Mike added long time ago. The feature is
>>> surely necessary for some users. So you can't remote it.
>> How would someone use that without blk_rq_append_bio()?  The only
> 
> Hmm, I'm not sure what you are talking about.
> 
> Why do we need to live without blk_rq_append_bio()?
> 
> You want to remove blk_rq_append_bio()? Please make your goal clear.

Yeah, I'm writing header message for the next patchset.  It will go
out in a few minutes.  With the bogus fix part removed, this patch
(and related earlier ones) should have been part of the next set.
And, yes, the goal is removing blk_rq_append_bio() and any and all
request/bio internal meddling with further patchsets.

>> reason blk_rq_map_user() had multiple bio chaining was to work around
>> BIO_MAX_SIZE.  blk_rq_map_user_iov() doesn't support multiple bio
>> chaining, so sans blk_rq_append_bio() or playing with rq/bio internals
>> directly, there's no way to use or even know about multiple bios.
> 
> Yes, only non iovec interface of SG_IO supports large data
> transfer. Users have been lived with that.

This patch doesn't remove any feature.  You don't lose anything.  What
used to be done with multiple bios is now done with single bio.  The
implementation is simpler and shorter.  Using or not using multiple
bios doesn't (and shouldn't) make any difference to blk_map_*() users.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/