Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763243AbZDANbS (ORCPT ); Wed, 1 Apr 2009 09:31:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758432AbZDANbD (ORCPT ); Wed, 1 Apr 2009 09:31:03 -0400 Received: from rv-out-0506.google.com ([209.85.198.237]:12943 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756622AbZDANbA convert rfc822-to-8bit (ORCPT ); Wed, 1 Apr 2009 09:31:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=BPC6Jx3xUOIZPQnXkk5x3Hji+DrjAbGujk4u3RZfDFEdw9jRCtt5cm+0wCyVY7u5jf U/OrJMLcvdDc5RqqBTZyDsSkfhI/DEhcyHPBx52bkNGv4EHkxThPLI2HaGgcRqcQYTFR plxd3bG/gGu6g4/k3xoQClTsHo0Q9jTHeD6UM= MIME-Version: 1.0 In-Reply-To: References: <28c262360903310338k20b8eebbncb86baac9b09e54@mail.gmail.com> <20090401165516.B1EB.A69D9226@jp.fujitsu.com> Date: Wed, 1 Apr 2009 22:30:58 +0900 X-Google-Sender-Auth: abddf120d38edb8f Message-ID: <2f11576a0904010630w5ab7aaa6wccf0a9d30b43bced@mail.gmail.com> Subject: Re: add_to_swap_cache with GFP_ATOMIC ? From: KOSAKI Motohiro To: Hugh Dickins Cc: Minchan Kim , linux-mm , lkml , Andrew Morton , Christoph Lameter , Nick Piggin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 728 Lines: 15 >> IOW, GFP_ATOMIC on add_to_swap() was introduced accidentally. the reason >> was old add_to_page_cache() didn't have gfp_mask parameter and we didn't >> ?have the reason of changing add_to_swap() behavior. >> I think it don't have deeply reason and changing GFP_NOIO >> don't cause regression. > > You may well be right: we'll see if you send in a patch to change it. > But I won't be sending in that patch myself, that's all :) OK, I'll queue it on my local patch queue. thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/