Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756540AbZDAQKh (ORCPT ); Wed, 1 Apr 2009 12:10:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754999AbZDAQK0 (ORCPT ); Wed, 1 Apr 2009 12:10:26 -0400 Received: from ti-out-0910.google.com ([209.85.142.190]:49862 "EHLO ti-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753712AbZDAQKZ (ORCPT ); Wed, 1 Apr 2009 12:10:25 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=mXjVTeVOMQGNGBZwHSDdWzFV2jkKs4BV1WBxCFMtQhfsfESGhjKdyQ19UDTCmc12SU W6gKdMUk3Tuhn0jdBNDoE3dMxxPmoBTUWvSAEPM56//nh/RvV+YJQVXHg2qN9awIfOp9 /gBwEj1nmUFgCMJbWY8mcHNxG3BkUgIUSQSFg= Date: Thu, 2 Apr 2009 00:11:14 +0800 From: =?utf-8?Q?Am=C3=A9rico?= Wang To: Miklos Szeredi Cc: user-mode-linux-devel@lists.sourceforge.net, jdike@addtoit.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: do_execve() needs const qualifiers (was Re: [patch 3/3] uml: fix warnings in kernel_execve) Message-ID: <20090401161114.GF3848@hack> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1879 Lines: 47 On Mon, Mar 30, 2009 at 08:45:12PM +0200, Miklos Szeredi wrote: >From: Miklos Szeredi > >Fix the following warnings: > >arch/um/kernel/syscall.c: In function 'kernel_execve': >arch/um/kernel/syscall.c:130: warning: passing argument 1 of 'um_execve' discards qualifiers from pointer target type >arch/um/kernel/syscall.c:130: warning: passing argument 2 of 'um_execve' discards qualifiers from pointer target type >arch/um/kernel/syscall.c:130: warning: passing argument 3 of 'um_execve' discards qualifiers from pointer target type > >Signed-off-by: Miklos Szeredi >--- > arch/um/kernel/syscall.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >Index: linux-2.6/arch/um/kernel/syscall.c >=================================================================== >--- linux-2.6.orig/arch/um/kernel/syscall.c 2009-03-30 20:25:17.000000000 +0200 >+++ linux-2.6/arch/um/kernel/syscall.c 2009-03-30 20:36:20.000000000 +0200 >@@ -127,7 +127,8 @@ int kernel_execve(const char *filename, > > fs = get_fs(); > set_fs(KERNEL_DS); >- ret = um_execve(filename, argv, envp); >+ ret = um_execve((char *)filename, (char __user *__user *)argv, >+ (char __user *__user *) envp); Well... I found this many days ago and I did a similar fix. However, I think this doesn't fix the real problem. The real problem is do_execve() doesn't have the correct const qualifiers, I am queueing a huge patch to fix all the 'const' issues from do_execve() and more, but I don't if Al would like it or not. So let's Cc Al to see his advice. Thanks. -- Do what you love, f**k the rest! F**k the regulations! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/