Message-ID: <49D3927A.2050406@zytor.com>
Date: Wed, 01 Apr 2009 09:12:42 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Thunderbird 2.0.0.14 (X11/20080501)
MIME-Version: 1.0
To: Andreas Robinson <andr345@gmail.com>
CC: Alain Knaff <alain@knaff.lu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] lib: add fast lzo decompressor
References: <1238593252-3435-1-git-send-email-andr345@gmail.com> <1238593252-3435-2-git-send-email-andr345@gmail.com>
In-Reply-To: <1238593252-3435-2-git-send-email-andr345@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1163
Lines: 32

Andreas Robinson wrote:
> This patch adds an LZO decompressor tweaked to be faster than
> the 'safe' decompressor already in the kernel.
> 
> On x86_64, it runs in roughly 80% of the time needed by the safe
> decompressor.
> 
> This function is inherently insecure and can cause buffer overruns.
> It is only intended for decompressing implicitly trusted data, such
> as an initramfs and the kernel itself.
> 
> As such, the function is neither exported nor declared in a header.
> 

OK, I'm more than a bit nervous about that, especially since we're
trying to make the decompression functions more generic.

Furthermore, is there a specific reason you didn't implent this for the
kernel itself as well as for the initramfs?  I'd really would strongly
prefer if the two compression sets didn't diverge.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/