Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934535AbZDAVyv (ORCPT ); Wed, 1 Apr 2009 17:54:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754897AbZDAVyk (ORCPT ); Wed, 1 Apr 2009 17:54:40 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51533 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909AbZDAVyk (ORCPT ); Wed, 1 Apr 2009 17:54:40 -0400 Date: Wed, 1 Apr 2009 14:50:41 -0700 From: Andrew Morton To: Manish Katiyar Cc: trivial@kernel.org, adilger@sun.com, mkatiyar@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] : Add dev-id and inode number for debugging in init_special_inode in fs/inode.c Message-Id: <20090401145041.6681fc90.akpm@linux-foundation.org> In-Reply-To: References: <20090330163317.a273a46a.akpm@linux-foundation.org> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 856 Lines: 23 On Tue, 31 Mar 2009 08:11:00 +0530 Manish Katiyar wrote: > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -1540,7 +1540,8 @@ void init_special_inode(struct inode *inode, umode_t mode, dev_t rdev) > else if (S_ISSOCK(mode)) > inode->i_fop = &bad_sock_fops; > else > - printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o)\n", > - mode); > + printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o) for" > + " inode %s:%lu\n", mode, inode->i_sb->s_id, > + inode->i_ino); > } Is ther a guarantee that inode->i_sb and inode->i_ino have been initialised at this time? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/