Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932238AbZDBQrx (ORCPT ); Thu, 2 Apr 2009 12:47:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765991AbZDBQqy (ORCPT ); Thu, 2 Apr 2009 12:46:54 -0400 Received: from www.tglx.de ([62.245.132.106]:54246 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765963AbZDBQqx (ORCPT ); Thu, 2 Apr 2009 12:46:53 -0400 Date: Thu, 2 Apr 2009 18:45:24 +0200 (CEST) From: Thomas Gleixner To: Will Schmidt cc: LKML , rt-users , Ingo Molnar , Steven Rostedt , Peter Zijlstra , Carsten Emde , Clark Williams , Frank Rowand , Robin Gareus , Gregory Haskins , Philippe Reynes , Fernando Lopez-Lezcano Subject: Re: [Announce] 2.6.29-rt2 In-Reply-To: <1238688145.8813.16.camel@lexx> Message-ID: References: <1238688145.8813.16.camel@lexx> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2259 Lines: 62 On Thu, 2 Apr 2009, Will Schmidt wrote: > On Thu, 2009-04-02 at 02:17 +0200, Thomas Gleixner wrote: > > We are pleased to announce the next update to our new preempt-rt > > series. > > > > - fix a fork/exit bug in the signal per task cache (/me puts on > > a huge brown paper bag - Thanks to Phillipe Reynes and Will > > Schmidt for reporting and testing) > > > > - fix a group scheduling migration accounting bug (decoded with > > and fixed by Peter Zijlstra - reported by Robin Gareus) > > > > - tlb gather rework by Peter Zijlstra - Thanks Peter ! > > > > - the usual fixlets > > > > The tlb rework might be incomplete on some of the uncountable > > incarnations of PowerPC and ARM platforms, so look out for wreckage > > and keep the usual tools (fire-extinguishers, brooms, buckets etc.) > > handy. > > I can confirm that the tlb rework does appear to be missing some parts > for Power. (Using 2.6.29-rt3 on pseries ppc64) > > arch/powerpc/kernel/built-in.o:(.toc1+0x4d0): undefined reference to > `per_cpu__ppc64_tlb_batch' > <...> > mm/built-in.o:(.toc1+0xed0): more undefined references to > `per_cpu__ppc64_tlb_batch' follow > > Not clear to me if this is just missing a "DEFINE_PER_CPU_LOCKED" to > replace the removed "DEFINE_PER_CPU", (similar to the prior RT patches), > or if the tlb rework is more involved. So, I will patiently remain > tuned in. :-) No, the DEFINE_PER_CPU was removed accidentaly. Should have stayed there Thanks, tglx -------- Index: linux-2.6-tip/arch/powerpc/mm/tlb_hash64.c =================================================================== --- linux-2.6-tip.orig/arch/powerpc/mm/tlb_hash64.c +++ linux-2.6-tip/arch/powerpc/mm/tlb_hash64.c @@ -32,6 +32,8 @@ #include #include +DEFINE_PER_CPU(struct ppc64_tlb_batch, ppc64_tlb_batch); + /* * A linux PTE was changed and the corresponding hash table entry * neesd to be flushed. This function will either perform the flush -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/