To: Andrew Patterson <andrew.patterson@hp.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
       jbarnes@virtuousgeek.org
Subject: Re: [PATCH] Add support for turning PCIe ECRC on or off
From: Andi Kleen <andi@firstfloor.org>
References: <20090402221751.11757.36392.stgit@bob.kio>
Date: Fri, 03 Apr 2009 08:54:39 +0200
In-Reply-To: <20090402221751.11757.36392.stgit@bob.kio> (Andrew Patterson's message of "Thu, 02 Apr 2009 16:17:51 -0600")
Message-ID: <87ljqikz0w.fsf@basil.nowhere.org>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 28

Andrew Patterson <andrew.patterson@hp.com> writes:

> Add support for turning PCIe ECRC on or off
>
> Adds support for PCI Express transaction layer end-to-end CRC checking
> (ECRC).  This patch will enable/disable ECRC checking by setting/clearing
> the ECRC Check Enable and/or ECRC Generation Enable bits for devices that
> support ECRC.
>
> The ECRC setting is controlled by the "pcie_ecrc=" command-line option. If
> this option is not set or is set to 'default", the enable and generation
> bits are left in whatever state that firmware/BIOS sets them to.  The
> "off" setting turns them off, and the "on" option turns them on (if the
> device supports it).

Can you please expand a little bit on your motvation? Why does the kernel
need to set that over the firmware? And why does it need to be a boot
parameter vs some sysfs file?

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/