Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761488AbZDCIdg (ORCPT ); Fri, 3 Apr 2009 04:33:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755303AbZDCIdS (ORCPT ); Fri, 3 Apr 2009 04:33:18 -0400 Received: from tundra.namei.org ([65.99.196.166]:3829 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbZDCIdQ (ORCPT ); Fri, 3 Apr 2009 04:33:16 -0400 Date: Fri, 3 Apr 2009 19:31:03 +1100 (EST) From: James Morris To: "David P. Quigley" cc: hch@infradead.org, viro@zeniv.linux.org.uk, casey@schaufler-ca.com, sds@tycho.nsa.gov, "Matthew N. Dodd" , trond.myklebust@fys.uio.no, bfields@fieldses.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, labeled-nfs@linux-nfs.org Subject: Re: [PATCH 08/14] NFSv4: Add label recommended attribute and NFSv4 flags In-Reply-To: <1227733394-1114-9-git-send-email-dpquigl@tycho.nsa.gov> Message-ID: References: <1227733394-1114-1-git-send-email-dpquigl@tycho.nsa.gov> <1227733394-1114-9-git-send-email-dpquigl@tycho.nsa.gov> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 34 On Wed, 26 Nov 2008, David P. Quigley wrote: > diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h > index ea03667..144eacf 100644 > --- a/include/linux/nfs4.h > +++ b/include/linux/nfs4.h > @@ -21,6 +21,7 @@ > #define NFS4_FHSIZE 128 > #define NFS4_MAXPATHLEN PATH_MAX > #define NFS4_MAXNAMLEN NAME_MAX > +#define NFS4_MAXLABELLEN 4096 I can't recall if this has been discussed before, but why is the label length limited to this value? SELinux on-disk labels can be up to 64KB in size (XATTR_SIZE_MAX), and I'd like to ensure that we don't end up with an unnecessary disk vs. network label size incompatibility. While it seems unlikely that SELinux (and other forms of MAC) security labels would currently exceed 4K, we don't know how SELinux might be extended in the future, and should avoid limiting label flexibility beyond existing constraints. - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/