Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760394AbZDCKei (ORCPT ); Fri, 3 Apr 2009 06:34:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756756AbZDCKeZ (ORCPT ); Fri, 3 Apr 2009 06:34:25 -0400 Received: from pmx1.sophos.com ([213.31.172.16]:38089 "EHLO pmx1.sophos.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755042AbZDCKeX (ORCPT ); Fri, 3 Apr 2009 06:34:23 -0400 X-Greylist: delayed 635 seconds by postgrey-1.27 at vger.kernel.org; Fri, 03 Apr 2009 06:34:23 EDT From: Tvrtko Ursulin Organization: Sophos Plc To: "Tvrtko A. Ursulin" Subject: Re: [Regression in 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29) Date: Fri, 3 Apr 2009 10:23:38 +0000 User-Agent: KMail/1.9.10 Cc: "Rafael J. Wysocki" , Pavel Machek , "linux-pm@lists.linux-foundation.org" , kernel list , Tobias Diedrich , Ayaz Abdulla , "netdev@vger.kernel.org" , Ed Swierk , Arthur Jones , Andrew Morton , "David S. Miller" , stable@kernel.org References: <200903261920.32173.tvrtko@ursulin.net> <200903272109.21259.rjw@sisk.pl> <200903290903.57911.tvrtko@ursulin.net> In-Reply-To: <200903290903.57911.tvrtko@ursulin.net> MIME-Version: 1.0 Message-Id: <200904031123.40390.tvrtko.ursulin@sophos.com> X-MIMETrack: Itemize by SMTP Server on Mercury/Servers/Sophos(Release 7.0.3|September 26, 2007) at 03/04/2009 11:23:45, Serialize by Router on Mercury/Servers/Sophos(Release 7.0.3|September 26, 2007) at 03/04/2009 11:23:45, Serialize complete at 03/04/2009 11:23:45 X-TNEFEvaluated: 1 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1204 Lines: 31 On Sunday 29 March 2009 09:03:57 Tvrtko A. Ursulin wrote: > On Friday 27 March 2009 20:09:20 Rafael J. Wysocki wrote: > > I was able to reproduce the problem and identify the commit that broke > > the resume of forcedeth, which turned out to be: > > > > commit cb52deba12f27af90a46d2f8667a64888118a888 > > Author: Ed Swierk > > Date: Mon Dec 1 12:24:43 2008 +0000 > > > > forcedeth: power down phy when interface is down > > > > Signed-off-by: Ed Swierk > > Tested-by: Arthur Jones > > Signed-off-by: Andrew Morton > > Signed-off-by: David S. Miller > > > > Since I have no slightest idea of what this commit is supposed to > > achieve, I can only ask for reverting it. It reverts cleanly, BTW. > > Reverting this fixes it for me as well. > > Thanks for your effort! Would reverting this be a -stable material? Tvrtko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/