Date: Fri, 3 Apr 2009 09:49:27 -0400
From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: nickpiggin@yahoo.com.au, hch@infradead.org, nfsv4@linux-nfs.org,
       linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] CacheFiles: Use the ->write() file op rather than
	a special kernel aop
Message-ID: <20090403134927.GA31907@infradead.org>
References: <20090403094138.9510.80681.stgit@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090403094138.9510.80681.stgit@warthog.procyon.org.uk>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 759
Lines: 26

On Fri, Apr 03, 2009 at 10:41:38AM +0100, David Howells wrote:
> +			if (!aops->bmap)
>  				goto check_error;

What are you doing using bmap?  You really shouldn't call into it from
anywhere but FIBMAP.  Yes, swap currently does but it's a major pain
in the neck and Peter has been working on a proper interface for swap
for a while.

> +	if (IS_ERR(file)) {
> +		ret = PTR_ERR(file);

		goto out_something;

> +	} else {
> +		ret = -EIO;
> +		if (file->f_op->write) {

	if (!file->f_op->write)
		goto out_fput;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/