DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=mime-version:reply-to:in-reply-to:references:date:message-id
         :subject:from:to:cc:content-type:content-transfer-encoding;
        b=FDXF/DTAWjkohJFV/eNdt4J2hqcvYD26nblF8rumG+7snHInMVQzUja/Z0E6bJQy8F
         LsgODLNY9+wVDeOZ8757Y/Aa0W/8AKkUDc5YlA83106/ZfHClQK6xkx95USsVsPEVZNT
         zrgGRTiZlHkKwdw86wfNceI1LaVapKdoJ42Vg=
MIME-Version: 1.0
Reply-To: petkovbb@gmail.com
In-Reply-To: <200904031241.44597.bzolnier@gmail.com>
References: <1238655519-10074-2-git-send-email-petkovbb@gmail.com>
	 <200904030108.39927.bzolnier@gmail.com>
	 <20090403045803.GA3732@liondog.tnic>
	 <200904031241.44597.bzolnier@gmail.com>
Date: Fri, 3 Apr 2009 16:03:08 +0200
Message-ID: <9ea470500904030703k9285e0eye5487f825df77e6@mail.gmail.com>
Subject: Re: [PATCH 2/3] ide-cd: cleanup cdrom_decode_status
From: Borislav Petkov <petkovbb@googlemail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1802
Lines: 40

On Fri, Apr 3, 2009 at 12:41 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> On Friday 03 April 2009, Borislav Petkov wrote:
>> Hi,
>>
>> On Fri, Apr 03, 2009 at 01:08:39AM +0200, Bartlomiej Zolnierkiewicz wrote:
>> > On Thursday 02 April 2009, Borislav Petkov wrote:
>> > > - have (almost) equal handling of commands based solely on sense_key
>> >
>> > I'm having a VERY hard time trying to review this patch because at
>> > the same time that codepaths were merged if()s were replaced by switch()
>> > which in turn resulted in change of intendation... on top of that
>> > the patch description is very vague about this part of the changes...
>>
>> I completely and exactly understand what you are saying :), I thought so
>> too when I looked at the diffs yesterday. Well, if it's any consolation, the
>> patches've been tested so they seem to work :). Anyway, split version coming
>> up...
>
> The split version looks exactly the same except ide_cd_breathe() change
> when it comes to the main part.
>
> Did you send the wrong version by any chance?

No, but I can't split those changes anymore logically. The switch-case handles
the differentiation based on the sense_key and as such cannot be broken down
anymore without doing some weird stuff and possibly introducing more bugs and
breaking bisectability. Completely hypothetically: wouldn't a before-after
juxtaposition of the change make reviewing more easier, for example you
apply the patch on a different branch and compare the before and the after
version?

-- 
Regards/Gruss,
Boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/