Subject: Re: [PATCH] leds: Increase trigger name maximum size
From: Richard Purdie <rpurdie@linux.intel.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
In-Reply-To: <49D536FA.2050307@lwfinger.net>
References: <49d5059a.f3z10uf0HvyIItSz%Larry.Finger@lwfinger.net>
	 <49D536FA.2050307@lwfinger.net>
Content-Type: text/plain
Date: Fri, 03 Apr 2009 15:45:04 +0100
Message-Id: <1238769904.5347.11.camel@dax.rpnet.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1038
Lines: 33


On Thu, 2009-04-02 at 17:06 -0500, Larry Finger wrote:
> Larry Finger wrote:
> > On my HP dv2815 laptop, the total length of the triggers for my b43legacy
> > wireless device exceeds the maximum value of 50 defined in
> > include/linux/leds.h. As a result, the list is garbled.
> > 
> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> > ---
> 
> Richard,
> 
> Please drop this. That length change is a red herring. Something is corrupting
> the list of triggers, but this length is not it.
> 
> Sorry for the noise.

I was about to raise some concerns about this patch as its just hiding
some underlying memory corruption. I don't think this is related to the
LED code but let me know if it turns out to be.

Cheers,

Richard
-- 
Richard Purdie
Intel Open Source Technology Centre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/