Date: Fri, 3 Apr 2009 17:36:17 +0200
From: Ingo Molnar <mingo@elte.hu>
To: markus.t.metzger@intel.com
Cc: tglx@linutronix.de, hpa@zytor.com, markus.t.metzger@gmail.com,
       roland@redhat.com, eranian@googlemail.com, oleg@redhat.com,
       juan.villacis@intel.com, ak@linux.jf.intel.com,
       linux-kernel@vger.kernel.org
Subject: Re: [patch 00/20] x86, ptrace, bts, hw-branch-tracer: fixes and
	cleanups
Message-ID: <20090403153617.GA15166@elte.hu>
References: <20090403144332.799740000@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090403144332.799740000@intel.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1390
Lines: 38


* markus.t.metzger@intel.com <markus.t.metzger@intel.com> wrote:

> Patches 1-5 fix races with context switching code when the branch 
> traced task is currently running.
> 
> In the worst case, this might cause context switch code to access 
> freed memory or the tracing hardware to continue tracing into a 
> freed buffer. Both might crash the kernel.
> 
> The first 4 patches apply to .29 using the below preparation 
> patch.
> 
> The remaining patches fix bugs in the context of per-cpu tracing 
> (i.e. hw-branch-tracer) and pebs, add more selftest code, and do 
> some cleanups.

Thanks - this looks pretty acceptable. Latest -git changed a lot of 
code in the same area (-mm bits went upstream), creating a lot of 
conflicts.

To not prolongue this any longer (20 patches are difficult enough 
already to handle) i picked up your patches and resolved the 
conflicts in situ - mind having a look at the resulting 
tip:tracing/hw-branch-tracing branch - does the end result look sane 
to you?

It would also be nice to address Peter's feedback about the mm.h 
detail and the locked-pages API - but we can do that on top.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/