Date: Fri, 3 Apr 2009 19:05:45 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Robert Richter <robert.richter@amd.com>, Paul Mackerras <paulus@samba.org>,
       Corey Ashford <cjashfor@linux.vnet.ibm.com>,
       linux-kernel@vger.kernel.org
Subject: Re: perf_counter: request for three more sample data options
Message-ID: <20090403170545.GE19982@elte.hu>
References: <49D56A7E.80908@linux.vnet.ibm.com> <1238742064.798.8.camel@twins> <49D5B9E7.1020400@linux.vnet.ibm.com> <1238745077.798.17.camel@twins> <18901.52735.579687.568717@cargo.ozlabs.ibm.com> <20090403163756.GH3226@erda.amd.com> <20090403164135.GB3047@elte.hu> <1238777954.798.266.camel@twins>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1238777954.798.266.camel@twins>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2564
Lines: 63


* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Fri, 2009-04-03 at 18:41 +0200, Ingo Molnar wrote:
> > * Robert Richter <robert.richter@amd.com> wrote:
> > 
> > > On 03.04.09 19:51:11, Paul Mackerras wrote:
> > > > Peter Zijlstra writes:
> > > > 
> > > > > What I was thinking of was re-using some of the cpu_clock()
> > > > > infrastructure. That provides us with a jiffy based GTOD sample,
> > > > > cpu_clock() then uses TSC and a few filters to compute a current
> > > > > timestamp.
> > > > > 
> > > > > I was thinking about cutting back those filters and thus trusting the
> > > > > TSC more -- which on x86 can do any random odd thing. So provided the
> > > > > TSC is not doing funny the results will be ok-ish.
> > > > > 
> > > > > This does mean however, that its not possible to know when its gone bad.
> > > > 
> > > > I would expect that perfmon would be just reading the TSC and
> > > > recording that.  If you can read the TSC and do some correction then
> > > > we're ahead. :)
> > > > 
> > > > > The question to Paul is, does the powerpc sched_clock() call work in NMI
> > > > > -- or hard irq disable -- context?
> > > > 
> > > > Yes - timekeeping is one area where us powerpc guys can be smug. 
> > > > :) We have a per-core, 64-bit timebase register which counts at 
> > > > a constant frequency and is synchronized across all cores.  So 
> > > > sched_clock works in any context on powerpc - all it does is 
> > > > read the timebase and do some simple integer arithmetic on it.
> > > 
> > > Ftrace is using ring_buffer_time_stamp() that finally uses 
> > > sched_clock(). But I am not sure if the time is correct when 
> > > calling from an NMI handler.
> > 
> > Yeah, that's a bit icky. Right now we have the following 
> > accelerator:
> > 
> > u64 sched_clock_cpu(int cpu)
> > {
> >         u64 now, clock, this_clock, remote_clock;
> >         struct sched_clock_data *scd;
> > 
> >         if (sched_clock_stable)
> >                 return sched_clock();
> > 
> > which works rather well on CPUs that set sched_clock_stable. Do you 
> > think we could set it on Barcelona?
> 
> I think you should couple it to the tsc clocksource detection 
> thingy. On all systems the tsc is good enough to use as 
> clocksource, we can short-circuit.

No principal objections, if it works.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/