Date: Fri, 3 Apr 2009 19:30:59 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Joseph Cihula <joseph.cihula@intel.com>, Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, arjan@linux.intel.com
Subject: Re: [PATCH] x86: disable stack-protector for
	__restore_processor_state()
Message-ID: <20090403173059.GO19982@elte.hu>
References: <49D13385.5060900@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49D13385.5060900@intel.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 935
Lines: 27


* Joseph Cihula <joseph.cihula@intel.com> wrote:

> The __restore_processor_state() fn restores %gs on resume from S3.  
> As such, it cannot be protected by the stack-protector guard since 
> %gs will not be correct on function entry.
>
> There are only a few other fns in this file and it should not 
> negatively impact kernel security that they will also have the 
> stack-protector guard removed (and so it's not worth moving them 
> to another file).
>
> Without this change, S3 resume on a kernel built with 
> CONFIG_CC_STACKPROTECTOR_ALL=y will fail.
>
> Signed-off-by:  Joseph Cihula <joseph.cihula@intel.com>

ah ... very nice!

applied to tip:x86/urgent, thanks Joseph!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/