Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936086AbZDCTv3 (ORCPT ); Fri, 3 Apr 2009 15:51:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934141AbZDCTuo (ORCPT ); Fri, 3 Apr 2009 15:50:44 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:41771 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935030AbZDCTun (ORCPT ); Fri, 3 Apr 2009 15:50:43 -0400 Date: Fri, 3 Apr 2009 15:50:40 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Zhaolei cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ftrace: Add check of sched_stopped for probe_sched_wakeup In-Reply-To: <49D1C543.3010307@cn.fujitsu.com> Message-ID: References: <49D1C51C.7000407@cn.fujitsu.com> <49D1C543.3010307@cn.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 641 Lines: 21 On Tue, 31 Mar 2009, Zhaolei wrote: > We need check sched_stopped in probe_sched_wakeup() to stop tracing when an > user stops it. > > But current code can also do the right thing(stop tracing after > echo 0 > tracing_enabled) just because tracing_sched_wakeup_trace() can return > on buffer->record_disabled. > > Signed-off-by: Zhao Lei Thanks, applied. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/