DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=mwkkOvzXUc8739oc1noaf6U7FhEBZVqpLfI2J72QnEBiToioCjYZBexAKVsq5By5y+
         /xKk5b6BDTgDMH2TTfvc4V82afsOqDQ5ZGP+TzHw7WT+t/emlyzRjwXiDn19guovTKR0
         jXxEep8mHedJCdeyDzzIlMy3WYJMap3G04g7c=
MIME-Version: 1.0
In-Reply-To: <504C2315A8%linux@youmustbejoking.demon.co.uk>
References: <504BBE2828%linux@youmustbejoking.demon.co.uk>
	 <20090404041813.GA30746@srcf.ucam.org>
	 <71cd59b00904040133p1f130673r4e93d2c48f8f4616@mail.gmail.com>
	 <504C2315A8%linux@youmustbejoking.demon.co.uk>
Date: Sat, 4 Apr 2009 14:35:26 +0200
Message-ID: <71cd59b00904040535t51f0e8bew34b487e0a3703f7e@mail.gmail.com>
Subject: Re: [PATCH 2.6.29] eeepc-laptop: report brightness control events via 
	the input layer
From: Corentin Chary <corentin.chary@gmail.com>
To: Corentin Chary <corentin.chary@gmail.com>,
       Matthew Garrett <mjg59@srcf.ucam.org>, linux-kernel@vger.kernel.org,
       acpi4asus-user@lists.sourceforge.net,
       Darren Salt <linux@youmustbejoking.demon.co.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 602
Lines: 18

>> How can brn be -2?
> If notify_brn() wasn't called, it will be.
Oh, yeah, I miss the if() before notify_brn()

>> And why -2?
> Because notify_brn() won't return it (and if it ever does, it needs to be
> fixed). (Yes, I know, "magic numbers" and all that...)
Maybe a negative known error code could be used here


-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/