Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755806AbZDDMlt (ORCPT ); Sat, 4 Apr 2009 08:41:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752172AbZDDMlj (ORCPT ); Sat, 4 Apr 2009 08:41:39 -0400 Received: from rv-out-0506.google.com ([209.85.198.224]:60655 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbZDDMli convert rfc822-to-8bit (ORCPT ); Sat, 4 Apr 2009 08:41:38 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=nCIvP4Lbs/KSXTeoJRSBGp8Eq17e6DoV9G62rl0GuTtpmRg/He+ncT9H/thhaQOYZt eIwZcHCn7Vuj1dkjWtZDhOxx2Fl6DB62MPhQHowJA25/qYPZu6WrNcy5TByeQS7KDyZ9 C1wvoJbfcbg4nMZmD8BKNfAZ0wP+fVqkip9lY= MIME-Version: 1.0 In-Reply-To: <1238679361.3383.4.camel@mulgrave.int.hansenpartnership.com> References: <200904020335.n323ZJVh004287@blc-10-2.brocade.com> <1238679361.3383.4.camel@mulgrave.int.hansenpartnership.com> Date: Sat, 4 Apr 2009 20:41:36 +0800 Message-ID: Subject: Re: [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile) From: Jing Huang To: James Bottomley Cc: Krishna Gudipati , huangj@brocade.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, nkattang@brocade.com, rvadivel@brocade.com, vravindr@brocade.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2105 Lines: 59 On Thu, Apr 2, 2009 at 9:36 PM, James Bottomley wrote: > On Wed, 2009-04-01 at 20:35 -0700, Krishna Gudipati wrote: >> From: Krishna Chaitanya Gudipati >> >> This patch contains Makefile and Kconfig file for scsi and bfa.Fixed >> the code review comments from previous submission. >> >> Signed-off-by: Krishna Chaitanya Gudipati >> --- >> ?Kconfig ? ? ?| ? ?9 +++++++++ >> ?Makefile ? ? | ? ?1 + >> ?bfa/Makefile | ? 27 +++++++++++++++++++++++++++ >> ?3 files changed, 37 insertions(+) >> >> diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig >> --- orig/drivers/scsi/Kconfig 2009-04-01 20:08:49.271161000 -0700 >> +++ patch/drivers/scsi/Kconfig ? ? ? ?2009-04-01 20:08:44.003822000 -0700 >> @@ -1797,6 +1797,15 @@ config SCSI_SRP >> ? ? ? ? To compile this driver as a module, choose M here: the >> ? ? ? ? module will be called libsrp. >> >> +config SCSI_BFA_FC >> + ? ? tristate "Brocade BFA Fibre Channel Support" >> + ? ? depends on PCI && SCSI >> + ? ? help >> + ? ? ? This bfa driver supports all Brocade PCIe Fibre Channel host adapters. >> + >> + ? ? ? To compile this driver as a module, choose M here. The module will >> + ? ? ? be called bfa. >> + > > You're still not using the FC transport class to export common sysfs FC > information or to help make your driver smaller. ?I thought you were > going to fix this after this was noted in your first submission to > linux-scsi on 24 September? > > James > > Hi James, We removed Brocade specific sysfs code after first linux-scsi submission. Can you please clarify where we are still not using the FC transport class to export common sysfs FC information? We do use the fc transport template to create the common sysfs FC attributes (in bfad_attr.c) under /sys/class/fc_host/ Thanks Jing -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/