Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751638AbZDEEBQ (ORCPT ); Sun, 5 Apr 2009 00:01:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750741AbZDEEA4 (ORCPT ); Sun, 5 Apr 2009 00:00:56 -0400 Received: from mail-bw0-f169.google.com ([209.85.218.169]:44083 "EHLO mail-bw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750712AbZDEEAz (ORCPT ); Sun, 5 Apr 2009 00:00:55 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=ECsvPlduapS7ZRg1ojy6dMFsrzUNFnlXAOuTsZdL49elhZhj7lTGQOJfGPYgUkpktB hbviwsVpw6yXRMyOGbRj5zOR8UqxM3GplQK4zvlZqxTmZytDOeI56HeSHeQFdFDilqBg vuITz/sMP21RQdOKoCUTKBaiISitJDNQwiwR0= MIME-Version: 1.0 In-Reply-To: <20090404.170539.148727646.davem@davemloft.net> References: <20090404.170539.148727646.davem@davemloft.net> Date: Sun, 5 Apr 2009 00:00:51 -0400 Message-ID: Subject: Re: [PATCH 1/1] Tell linkwatch about new interfaces From: Andrew Lutomirski To: David Miller Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2179 Lines: 61 On Sat, Apr 4, 2009 at 8:05 PM, David Miller wrote: > From: Andrew Lutomirski > Date: Wed, 1 Apr 2009 11:40:06 -0400 > >> When a network driver registers a new interface, linkwatch will not notice, >> and hence not set the rfc2863 operstate, until netif_carrier_on gets called. >> If the new interface has no carrier when it is connected, then a status of >> "unknown" is reported to userspace, which confuses various tools >> (NetworkManager, for example). >> >> This fires a linkwatch event for all new interfaces, so that operstate >> gets set reasonably quickly. >> >> Signed-off-by: Andrew Lutomirski > > The default assumed state for a freshly registered network > device is that the link is up. > > If that disagrees from reality, the driver should make the > appropriate netif_carrier_off() call. > > I'm sure you'll find that the e1000 driver is not doing this > and that is what causes the bug you are seeing. > Nope. The end of e1000_probe (in e1000e) is: /* tell the stack to leave us alone until e1000_open() is called */ netif_carrier_off(netdev); netif_tx_stop_all_queues(netdev); strcpy(netdev->name, "eth%d"); err = register_netdev(netdev); if (err) goto err_register; e1000_print_device_info(adapter); netif_carrier_off does: void netif_carrier_off(struct net_device *dev) { if (!test_and_set_bit(__LINK_STATE_NOCARRIER, &dev->state)) { if (dev->reg_state == NETREG_UNINITIALIZED) return; linkwatch_fire_event(dev); } } So, either it should be illegal to call netif_carrier_off on an unregistered net_device (and there should be a WARN() in netif_carrier_off), or it should work correctly, and register_netdevice should do the right thing when there is no carrier (i.e. something like my patch). --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/