Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758340AbZDFB23 (ORCPT ); Sun, 5 Apr 2009 21:28:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753964AbZDFB2T (ORCPT ); Sun, 5 Apr 2009 21:28:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50409 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753374AbZDFB2S (ORCPT ); Sun, 5 Apr 2009 21:28:18 -0400 Date: Mon, 06 Apr 2009 03:28:13 +0200 Message-ID: From: Takashi Iwai To: Adrian McMenamin Cc: Paul Mundt , Alsa-devel , LKML , linux-sh Subject: Re: [PATCH] snd: aica - fix annoying compiler warning In-Reply-To: <1238629310.7455.0.camel@localhost.localdomain> References: <1237154740.6636.4.camel@localhost.localdomain> <1237190049.6513.3.camel@localhost.localdomain> <20090330231043.GF19535@linux-sh.org> <1238629310.7455.0.camel@localhost.localdomain> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2002 Lines: 57 At Thu, 02 Apr 2009 00:41:50 +0100, Adrian McMenamin wrote: > > On Tue, 2009-03-31 at 08:10 +0900, Paul Mundt wrote: > > On Mon, Mar 16, 2009 at 08:59:20AM +0100, Takashi Iwai wrote: > > > At Mon, 16 Mar 2009 07:54:09 +0000, > > > Adrian McMenamin wrote: > > > > > > > > On Mon, 2009-03-16 at 07:31 +0100, Takashi Iwai wrote: > > > > > At Sun, 15 Mar 2009 22:05:40 +0000, > > > > > Adrian McMenamin wrote: > > > > > > > > > > > > Cast pointer to data member of struct firmware as a void to end an > > > > > > annoying compiler warning. > > > > > > > > > > > > fix annoying compiler warning > > > > > > > > > > > > Signed-off-by: Adrian McMenamin > > > > > > --- > > > > > > > > > > > > diff --git a/sound/sh/aica.c b/sound/sh/aica.c > > > > > > index 7c920f3..822b119 100644 > > > > > > --- a/sound/sh/aica.c > > > > > > +++ b/sound/sh/aica.c > > > > > > @@ -567,7 +567,7 @@ static int load_aica_firmware(void) > > > > > > return err; > > > > > > /* write firware into memory */ > > > > > > spu_disable(); > > > > > > - spu_memload(0, fw_entry->data, fw_entry->size); > > > > > > + spu_memload(0, (void *)fw_entry->data, fw_entry->size); > > > > > > > > > > IMO, it's better to fix spu_memload() to take const pointer instead of > > > > > cast. > > > > > > > > > > > > > If that's what you want I can do that but it adds to kernel bloat by > > > > having two functions essentially do the same thing. > > > > > > I meant a fix like below... > > > > > Is anything happening with this, or should I just ignore it? > > > > I though Takashi's fix was fine/obvious but it doesn't appear to have > been pushed upstream (yet?) Well, then it'd be appreciated if you repost your patch with my fix. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/