Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754726AbZDFCJw (ORCPT ); Sun, 5 Apr 2009 22:09:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753550AbZDFCJm (ORCPT ); Sun, 5 Apr 2009 22:09:42 -0400 Received: from cantor.suse.de ([195.135.220.2]:52767 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753398AbZDFCJl (ORCPT ); Sun, 5 Apr 2009 22:09:41 -0400 Date: Mon, 06 Apr 2009 04:09:38 +0200 Message-ID: From: Takashi Iwai To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, Andrew Morton , Takashi Iwai , Jaroslav Kysela , Johannes Berg , Rene Herman Subject: Re: [PATCH 49/58] move snd_powermac's probe function to .devinit.text In-Reply-To: <1238196439-16535-49-git-send-email-u.kleine-koenig@pengutronix.de> References: <20090327232153.GA16348@pengutronix.de> <1238196439-16535-49-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1686 Lines: 50 At Sat, 28 Mar 2009 00:27:10 +0100, Uwe Kleine-K?nig wrote: > > A pointer to snd_pmac_probe is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (when having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver. > > Signed-off-by: Uwe Kleine-K?nig > Cc: Takashi Iwai > Cc: Jaroslav Kysela > Cc: Johannes Berg > Cc: Rene Herman > Cc: Andrew Morton Applied now to sound git tree. Thanks. Takashi > --- > sound/ppc/powermac.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/ppc/powermac.c b/sound/ppc/powermac.c > index 5a92906..a2b69b8 100644 > --- a/sound/ppc/powermac.c > +++ b/sound/ppc/powermac.c > @@ -51,7 +51,7 @@ static struct platform_device *device; > /* > */ > > -static int __init snd_pmac_probe(struct platform_device *devptr) > +static int __devinit snd_pmac_probe(struct platform_device *devptr) > { > struct snd_card *card; > struct snd_pmac *chip; > -- > 1.6.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/