Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759703AbZDGByf (ORCPT ); Mon, 6 Apr 2009 21:54:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752730AbZDGBy0 (ORCPT ); Mon, 6 Apr 2009 21:54:26 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:45141 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbZDGByZ (ORCPT ); Mon, 6 Apr 2009 21:54:25 -0400 Date: Mon, 6 Apr 2009 21:54:23 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Zhaolei cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ftrace: Code cleanup for kernel/trace/trace_events_stage_*.h In-Reply-To: <49D5E44B.3080104@cn.fujitsu.com> Message-ID: References: <49D5E3EE.70201@cn.fujitsu.com> <49D5E44B.3080104@cn.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 28 On Fri, 3 Apr 2009, Zhaolei wrote: > Add TRACE_FORMAT's define for trace_events_stage_2.h. > Although it is already defined in trace_events_stage_1.h, we should make each > function independence. > > Move TP_fast_assign's define from trace_events_stage_2.h to > trace_events_stage_3.h because it is used there. > > Unify TRACE_EVENT's 5th argument's name to "assign" > > Impact: cleanup, no functionality changed > > Signed-off-by: Zhao Lei I see what you are doing here, but I'm a little hesitant to apply it. I'm getting ready to travel, so I do not have the time to look deeper at this today. I'll try to do it while I'm traveling. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/