Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759918AbZDGGkh (ORCPT ); Tue, 7 Apr 2009 02:40:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754594AbZDGGk1 (ORCPT ); Tue, 7 Apr 2009 02:40:27 -0400 Received: from gate.crashing.org ([63.228.1.57]:60490 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752997AbZDGGk0 (ORCPT ); Tue, 7 Apr 2009 02:40:26 -0400 Cc: beckyb@kernel.crashing.org, linux-kernel@vger.kernel.org, mingo@elte.hu, jeremy@goop.org, ian.campbell@citrix.com Message-Id: From: Kumar Gala To: FUJITA Tomonori In-Reply-To: <20090407112247W.fujita.tomonori@lab.ntt.co.jp> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: [PATCH 5/7] swiotlb: (re)Create swiotlb_unmap_single Date: Tue, 7 Apr 2009 01:34:44 -0500 References: <1238810209-24499-4-git-send-email-beckyb@kernel.crashing.org> <1238810209-24499-5-git-send-email-beckyb@kernel.crashing.org> <1238810209-24499-6-git-send-email-beckyb@kernel.crashing.org> <20090407112247W.fujita.tomonori@lab.ntt.co.jp> X-Mailer: Apple Mail (2.930.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1527 Lines: 42 On Apr 6, 2009, at 9:24 PM, FUJITA Tomonori wrote: > On Fri, 3 Apr 2009 20:56:47 -0500 > Becky Bruce wrote: > >> This mirrors the current swiotlb_sync_single() setup >> where the swiotlb_unmap_single() function is static to this >> file and contains the logic required to determine if we need >> to call actual sync_single. Previously, swiotlb_unmap_page >> and swiotlb_unmap_sg were duplicating very similar code. >> The duplicated code has also been reformatted for >> readability. >> >> Note that the swiotlb_unmap_sg code was previously doing >> a complicated comparison to determine if an addresses needed >> to be unmapped where a simple is_swiotlb_buffer() call >> would have sufficed. >> >> Signed-off-by: Becky Bruce >> --- >> lib/swiotlb.c | 36 +++++++++++++++++++++++------------- >> 1 files changed, 23 insertions(+), 13 deletions(-) >> >> diff --git a/lib/swiotlb.c b/lib/swiotlb.c >> index af2ec25..602315b 100644 >> --- a/lib/swiotlb.c >> +++ b/lib/swiotlb.c > > I don't think 'swiotlb_unmap_single' name is appropriate. > > swiotlb_unmap_single sounds like an exported function that IOMMUs can > use (and it was) however it should not be. What do you suggest we call it? __swiotlb_unmap_single. - k -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/