Date: Tue, 07 Apr 2009 21:49:23 +0900 (JST)
Message-Id: <20090407.214923.126142447.anemo@mba.ocn.ne.jp>
To: peterz@infradead.org
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
       linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH] rtc-ds1553: Drop IRQF_DISABLED
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <1239046422.798.4803.camel@twins>
References: <1239036633-10032-2-git-send-email-anemo@mba.ocn.ne.jp>
	<1239046422.798.4803.camel@twins>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 774
Lines: 21

On Mon, 06 Apr 2009 21:33:42 +0200, Peter Zijlstra <peterz@infradead.org> wrote:
> > IRQF_DISABLED should be be used with IRQF_SHARED.  Drop IRQF_DISABLED
> > and add spin_lock_irqsave/spin_unlock_irqrestore to the interrupt
> > handler.
> 
> I think you should use IRQF_DISABLED if at all possible. Only broken
> hardware has an excuse not to.
> 
> NAK

OK, then I will drop IRQF_SHARED instead.  There is no in-tree user of
this driver and only out-of-tree user I know uses dedicated irq line
for this RTC.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/