Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762037AbZDGWXj (ORCPT ); Tue, 7 Apr 2009 18:23:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755164AbZDGWX3 (ORCPT ); Tue, 7 Apr 2009 18:23:29 -0400 Received: from one.firstfloor.org ([213.235.205.2]:56341 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755340AbZDGWX3 (ORCPT ); Tue, 7 Apr 2009 18:23:29 -0400 Date: Wed, 8 Apr 2009 00:25:43 +0200 From: Andi Kleen To: Christoph Lameter Cc: Andi Kleen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH] [5/16] POISON: Add support for poison swap entries Message-ID: <20090407222543.GB17934@one.firstfloor.org> References: <20090407509.382219156@firstfloor.org> <20090407151002.0AA8F1D046E@basil.firstfloor.org> <20090407215605.GZ17934@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1450 Lines: 38 On Tue, Apr 07, 2009 at 05:56:28PM -0400, Christoph Lameter wrote: > On Tue, 7 Apr 2009, Andi Kleen wrote: > > > On Tue, Apr 07, 2009 at 05:11:26PM -0400, Christoph Lameter wrote: > > > > > > Could you separate the semantic changes to flag checking for migration > > > > You mean to try_to_unmap? > > I mean the changes to checking the pte contents for a migratable / > swappable page. Those are significant independent from this patchset and > would be useful to review independently. Sorry I'm still not quite sure what you're asking for. Are you asking about the fault path or about try_to_unmap or some other path? And why do you want a separate patchset versus merely a separate patch? (afaik the patches to generic code are already pretty separated) I don't really change the semantics of the migration or swap code itself for example. At least not consciously. If I did that would be a bug. e.g. the changes to try_to_unmap are two stages: - add flags/action code. Everything should still do the same, just the flags are passed around differently. - add a check for an already poisoned page and insert a poison swap entry for those -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/