Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762121AbZDGW1Z (ORCPT ); Tue, 7 Apr 2009 18:27:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758066AbZDGW1F (ORCPT ); Tue, 7 Apr 2009 18:27:05 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:46398 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754542AbZDGW1C (ORCPT ); Tue, 7 Apr 2009 18:27:02 -0400 Message-ID: <49DBD32F.3090703@garzik.org> Date: Tue, 07 Apr 2009 18:26:55 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Matthew Wilcox CC: Bartlomiej Zolnierkiewicz , Sergei Shtylyov , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, jgarzik@redhat.com, David Woodhouse Subject: Re: [PATCH 4/5] ide: Add support for TRIM References: <1238683047-13588-1-git-send-email-willy@linux.intel.com> <20090402165117.GQ2661@linux.intel.com> <200904022137.35671.bzolnier@gmail.com> <200904072339.00224.bzolnier@gmail.com> <20090407221554.GA4527@linux.intel.com> In-Reply-To: <20090407221554.GA4527@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 836 Lines: 23 Matthew Wilcox wrote: > On Tue, Apr 07, 2009 at 11:38:59PM +0200, Bartlomiej Zolnierkiewicz wrote: >> I would like to see this merged for -rc1 so I tried to put it altogether >> and then integrate it over recent IDE and block changes... > > You're missing 1/5 and 2/5. This patch will crash horribly if you use > it with a drive which supports TRIM. For things that need to hit along with the block layer, Bart and I could Ack the IDE+libata patches, and Jens could merge all of them. Or just poke Jens to review and merge the block stuff. Then the rest can go at any time. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/