Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753422AbZDHDRv (ORCPT ); Tue, 7 Apr 2009 23:17:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751287AbZDHDRl (ORCPT ); Tue, 7 Apr 2009 23:17:41 -0400 Received: from ozlabs.org ([203.10.76.45]:37119 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbZDHDRl (ORCPT ); Tue, 7 Apr 2009 23:17:41 -0400 From: Rusty Russell To: Peter Zijlstra Subject: Re: pm-hibernate : possible circular locking dependency detected Date: Wed, 8 Apr 2009 12:47:08 +0930 User-Agent: KMail/1.11.2 (Linux/2.6.27-11-generic; KDE/4.2.2; i686; ; ) Cc: Ingo Molnar , "Rafael J. Wysocki" , Ming Lei , Andrew Morton , "Linux-pm mailing list" , Linux Kernel List , Gautham R Shenoy References: <200904071356.29914.rusty@rustcorp.com.au> <1239087953.798.5513.camel@twins> In-Reply-To: <1239087953.798.5513.camel@twins> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904081247.08712.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 765 Lines: 21 On Tuesday 07 April 2009 16:35:53 Peter Zijlstra wrote: > On Tue, 2009-04-07 at 13:56 +0930, Rusty Russell wrote: > > Looks like this will be fixed by Andrew's work-on-cpu-in-own-thread > > patch which I just put out the pull request for. > > Would it make sense to teach it about a short-circuit like: > > work_on_cpu() { > > if (cpumask_weight(current->cpus_allowed) == 1 && > smp_processor_id() == cpu) > return do_work_right_here(); Does that happen much? I guess put a counter in and see? Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/