Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762838AbZDHHJZ (ORCPT ); Wed, 8 Apr 2009 03:09:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762761AbZDHHJJ (ORCPT ); Wed, 8 Apr 2009 03:09:09 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:39034 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760876AbZDHHJH (ORCPT ); Wed, 8 Apr 2009 03:09:07 -0400 Date: Wed, 8 Apr 2009 16:07:33 +0900 From: KAMEZAWA Hiroyuki To: balbir@linux.vnet.ibm.com Cc: "linux-mm@kvack.org" , Andrew Morton , "lizf@cn.fujitsu.com" , Rik van Riel , Bharata B Rao , Dhaval Giani , KOSAKI Motohiro , "linux-kernel@vger.kernel.org" Subject: Re: [RFI] Shared accounting for memory resource controller Message-Id: <20090408160733.4813cb8d.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090408070401.GC7082@balbir.in.ibm.com> References: <20090407063722.GQ7082@balbir.in.ibm.com> <20090407160014.8c545c3c.kamezawa.hiroyu@jp.fujitsu.com> <20090407071825.GR7082@balbir.in.ibm.com> <20090407163331.8e577170.kamezawa.hiroyu@jp.fujitsu.com> <20090407080355.GS7082@balbir.in.ibm.com> <20090407172419.a5f318b9.kamezawa.hiroyu@jp.fujitsu.com> <20090408052904.GY7082@balbir.in.ibm.com> <20090408151529.fd6626c2.kamezawa.hiroyu@jp.fujitsu.com> <20090408070401.GC7082@balbir.in.ibm.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1563 Lines: 42 On Wed, 8 Apr 2009 12:34:01 +0530 Balbir Singh wrote: > * KAMEZAWA Hiroyuki [2009-04-08 15:15:29]: > > > On Wed, 8 Apr 2009 10:59:04 +0530 > > Balbir Singh wrote: > > > > > > > > no serious intention. > > > > Just because you wrote "expect the user to account all cached pages as shared" ;) > > > > > > > > > > OK, I noticed another thing, our RSS accounting is not RSS per-se, it > > > includes only anon RSS, file backed pages are accounted as cached. > > > I'll send out a patch to see if we can include anon RSS as well. > > > > > > > I think we can't do it in memcg layer without new-hook because file caches > > are added to radix-tree before mapped. > > > > mm struct has anon_rss and file_rss coutners. Then, you can show > > sum of total maps of file pages. maybe. > > > > Yes, correct and that is a hook worth adding, IMHO. Better statistics > are critical and it will also help us with the shared memory > accounting. Without that we can't account for file rss in the memory > cgroup. > Finally, you'll be asked "is it necessary ?", if the cost is big. >From my point of view, I can't see what new information it will give us. But maybe useful because the user can avoid some calculation. Cheers, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/