Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762902AbZDHIGO (ORCPT ); Wed, 8 Apr 2009 04:06:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761876AbZDHIFU (ORCPT ); Wed, 8 Apr 2009 04:05:20 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:42188 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762050AbZDHIFN (ORCPT ); Wed, 8 Apr 2009 04:05:13 -0400 Date: Wed, 8 Apr 2009 17:03:41 +0900 From: KAMEZAWA Hiroyuki To: balbir@linux.vnet.ibm.com Cc: "linux-mm@kvack.org" , Andrew Morton , "lizf@cn.fujitsu.com" , Rik van Riel , Bharata B Rao , Dhaval Giani , KOSAKI Motohiro , "linux-kernel@vger.kernel.org" Subject: Re: [RFI] Shared accounting for memory resource controller Message-Id: <20090408170341.437c215b.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090408074809.GF7082@balbir.in.ibm.com> References: <20090407071825.GR7082@balbir.in.ibm.com> <20090407163331.8e577170.kamezawa.hiroyu@jp.fujitsu.com> <20090407080355.GS7082@balbir.in.ibm.com> <20090407172419.a5f318b9.kamezawa.hiroyu@jp.fujitsu.com> <20090408052904.GY7082@balbir.in.ibm.com> <20090408151529.fd6626c2.kamezawa.hiroyu@jp.fujitsu.com> <20090408070401.GC7082@balbir.in.ibm.com> <20090408160733.4813cb8d.kamezawa.hiroyu@jp.fujitsu.com> <20090408071115.GD7082@balbir.in.ibm.com> <20090408161824.26f47077.kamezawa.hiroyu@jp.fujitsu.com> <20090408074809.GF7082@balbir.in.ibm.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 43 On Wed, 8 Apr 2009 13:18:09 +0530 Balbir Singh wrote: > > > 3. Using the above, we can then try to (using an algorithm you > > > proposed), try to do some work for figuring out the shared percentage. > > > > > This is the point. At last. Why "# of shared pages" is important ? > > > > I posted this in my motivation yesterday. # of shared pages can help > plan the system better and the size of the cgroup. A cgroup might have > small usage_in_bytes but large number of shared pages. We need a > metric that can help figure out the fair usage of the cgroup. > I don't fully understand but NR_FILE_MAPPED is an information in /proc/meminfo. I personally think I want to support information in /proc/meminfo per memcg. Hmm ? then, if you add a hook, it seems == mm/rmap.c 689 void page_add_file_rmap(struct page *page) 690 { 691 if (atomic_inc_and_test(&page->_mapcount)) 692 __inc_zone_page_state(page, NR_FILE_MAPPED); 693 } == page_remove_rmap(struct page *page) 739 __dec_zone_page_state(page, 740 PageAnon(page) ? NR_ANON_PAGES : NR_FILE_MAPPED); == Is good place to go, maybe. page->page_cgroup->mem_cgroup-> inc/dec counter ? Maybe the patch itself will be simple, overhead is unknown.. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/