Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764976AbZDHL4Q (ORCPT ); Wed, 8 Apr 2009 07:56:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932485AbZDHLbr (ORCPT ); Wed, 8 Apr 2009 07:31:47 -0400 Received: from mail-fx0-f158.google.com ([209.85.220.158]:49619 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932487AbZDHLbq convert rfc822-to-8bit (ORCPT ); Wed, 8 Apr 2009 07:31:46 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=pWE5CIA41FqvrfJ+w5zwmwT9dirxZ7cjhuuuXNrD/pQAYF/tQJlIEv7mlYk3Yhx/Qr X56bKXAGONjUhyBFzWO6BiklFGwWLKLz6kxp8J3EtTgM3DZ0jcIKHRWgeDpd3wLelC4C WCs0llLrmCe9/EqtnzScymZ5vU2cGU6lhBuPw= MIME-Version: 1.0 In-Reply-To: <1239189748-11703-6-git-send-email-jwjstone@fastmail.fm> References: <1239189748-11703-1-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-2-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-3-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-4-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-5-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-6-git-send-email-jwjstone@fastmail.fm> Date: Wed, 8 Apr 2009 13:31:43 +0200 Message-ID: <36ca99e90904080431o3fae1c2es555327578ab06d7@mail.gmail.com> Subject: Re: [PATCH 05/56] block: Remove void casts From: Bert Wesarg To: Jack Stone Cc: linux-kernel@vger.kernel.org, jeff@garzik.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2215 Lines: 54 On Wed, Apr 8, 2009 at 13:21, Jack Stone wrote: > Remove uneeded void casts > > Signed-Off-By: Jack Stone > --- >  drivers/block/amiflop.c    |    2 +- >  drivers/block/cciss.c      |   11 ++++------- >  drivers/block/cciss_scsi.c |    3 +-- >  drivers/block/cpqarray.c   |    2 +- >  drivers/block/sx8.c        |    2 +- >  drivers/block/viodasd.c    |    3 +-- >  6 files changed, 9 insertions(+), 14 deletions(-) > > diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c > index 8df436f..702667b 100644 > --- a/drivers/block/amiflop.c > +++ b/drivers/block/amiflop.c > @@ -1727,7 +1727,7 @@ static int __init amiga_floppy_init(void) >        } > >        ret = -ENOMEM; > -       if ((raw_buf = (char *)amiga_chip_alloc (RAW_BUF_SIZE, "Floppy")) == > +       if ((raw_buf = amiga_chip_alloc (RAW_BUF_SIZE, "Floppy")) == ^ Could you feed the patches through checkpatch.pl to find and fix these style issues. >            NULL) { This line could be fit now at the previous line. >                printk("fd: cannot get chip mem buffer\n"); >                goto out_memregion; > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c > index 0ef6f08..0c4747a 100644 > --- a/drivers/block/cciss.c > +++ b/drivers/block/cciss.c > @@ -452,7 +452,7 @@ static CommandList_struct *cmd_alloc(ctlr_info_t *h, int get_from_pool) >        dma_addr_t cmd_dma_handle, err_dma_handle; > >        if (!get_from_pool) { > -               c = (CommandList_struct *) pci_alloc_consistent(h->pdev, > +               c = pci_alloc_consistent(h->pdev, >                        sizeof(CommandList_struct), &cmd_dma_handle); If typeof(c) == CommandList_struct*, that you could replace sizeof(CommandList_struct) with sizeof(*c) to make the expression shorter and fit into one line. Bert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/