Date: Wed, 8 Apr 2009 13:42:03 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
       Suresh B Siddha <suresh.b.siddha@intel.com>,
       Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
       svaidy@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com,
       dipankar@in.ibm.com, Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] Don't export sched_mc_power_savings on multi-socket
	single core system
Message-ID: <20090408114203.GA30441@elte.hu>
References: <49DC89A3.3090605@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49DC89A3.3090605@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1093
Lines: 25


* Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com> wrote:

> Fix to prevent sched_mc_power_saving from being exported through 
> sysfs for multi-scoket single core system. Max cores should be 
> always greater than one (1). My earlier patch that introduced fix 
> for not exporting 'sched_mc_power_saving' on laptops broke it on 
> multi-socket single core system. This fix addresses issue on both 
> laptop and multi-socket single core system. Below are the Test 
> results:

> +#define mc_capable()   (boot_cpu_data.x86_max_cores > 1) && \
> +                       (cpumask_weight(cpu_core_mask(0)) != nr_cpu_ids)
> #define smt_capable()                  (smp_num_siblings > 1)

patch looks good but is whitespace damaged (all tabs were converted 
to spaces). See Documentation/email-clients.txt about how to set up 
your client.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/