Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752696AbZDHMOT (ORCPT ); Wed, 8 Apr 2009 08:14:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758599AbZDHMEU (ORCPT ); Wed, 8 Apr 2009 08:04:20 -0400 Received: from mail-bw0-f169.google.com ([209.85.218.169]:61535 "EHLO mail-bw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932416AbZDHMET convert rfc822-to-8bit (ORCPT ); Wed, 8 Apr 2009 08:04:19 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=eESKghEZM0OFWb2RksCEsAzmmkOoYdKQilY2xOW7z5YTcCGtCAHL1L7TzyCrDhYp69 dHuPdJ2X64ukFZ9fTnU5LpyS8ksealduSK8oxJ7NS92HjbVqNC3rD4JUt2hYs1O3LvDt 6WAfk2WJ+fmw+/exiLxFSibbyMzBV6UPk7UZs= MIME-Version: 1.0 In-Reply-To: <36ca99e90904080502w1a9d703dg49a872b5539c3a9f@mail.gmail.com> References: <1239189748-11703-1-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-45-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-46-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-47-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-48-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-49-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-50-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-51-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-52-git-send-email-jwjstone@fastmail.fm> <36ca99e90904080502w1a9d703dg49a872b5539c3a9f@mail.gmail.com> Date: Wed, 8 Apr 2009 14:04:16 +0200 Message-ID: <36ca99e90904080504i74b16d61m3f7b235717e1f909@mail.gmail.com> Subject: Re: [PATCH 51/56] sysv: Remove void casts From: Bert Wesarg To: Jack Stone Cc: linux-kernel@vger.kernel.org, jeff@garzik.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 35 On Wed, Apr 8, 2009 at 14:02, Bert Wesarg wrote: > On Wed, Apr 8, 2009 at 13:22, Jack Stone wrote: >> Remove uneeded void casts >> >> Signed-Off-By: Jack Stone >> --- >>  fs/sysv/dir.c |   14 +++++++------- >>  1 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/fs/sysv/dir.c b/fs/sysv/dir.c >> index 56f6552..8a9f5a7 100644 >> --- a/fs/sysv/dir.c >> +++ b/fs/sysv/dir.c >> @@ -367,7 +367,7 @@ struct sysv_dir_entry * sysv_dotdot (struct inode *dir, struct page **p) >>        struct sysv_dir_entry *de = NULL; >> >>        if (!IS_ERR(page)) { >> -               de = (struct sysv_dir_entry*) page_address(page) + 1; >> +               de = page_address(page) + 1; > This is probably wrong, because (void* + 1) != (struct sysv_dir_entry* + 1). > Yeah, with this in mind I need to check all your patches again ;-) >>                *p = page; >>        } >>        return de; >> -- > > Bert > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/