Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759367AbZDHMPK (ORCPT ); Wed, 8 Apr 2009 08:15:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933641AbZDHMGf (ORCPT ); Wed, 8 Apr 2009 08:06:35 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:40581 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933635AbZDHMGe (ORCPT ); Wed, 8 Apr 2009 08:06:34 -0400 Date: Wed, 8 Apr 2009 14:06:27 +0200 From: Ingo Molnar To: Zhaolei Cc: Steven Rostedt , Frederic Weisbecker , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ftrace: Output REC->var instead of __entry->var for trace format Message-ID: <20090408120627.GA17179@elte.hu> References: <49DC6751.30308@cn.fujitsu.com> <49DC679D.2090901@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49DC679D.2090901@cn.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 855 Lines: 26 * Zhaolei wrote: > print fmt: "irq=%d return=%s", __entry->irq, __entry->ret ? \"handled\" : \"unhandled\" > > "__entry" should be convert to "REC" by __stringify() macro. > > Signed-off-by: Zhao Lei > --- > kernel/trace/trace_events_stage_2.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) good fix, but it is causing build trouble when applied to latest tip/master: include/trace/sched_event_types.h:257:1: error: macro "__stringify" passed 3 arguments, but takes just 1 see: http://people.redhat.com/mingo/tip.git/README Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/