Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764430AbZDHMgz (ORCPT ); Wed, 8 Apr 2009 08:36:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754615AbZDHMgp (ORCPT ); Wed, 8 Apr 2009 08:36:45 -0400 Received: from miranda.se.axis.com ([193.13.178.8]:54999 "EHLO miranda.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753814AbZDHMgp (ORCPT ); Wed, 8 Apr 2009 08:36:45 -0400 Date: Wed, 8 Apr 2009 14:35:37 +0200 From: Jesper Nilsson To: Jack Stone Cc: "linux-kernel@vger.kernel.org" , "jeff@garzik.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH 08/56] cris: Remove void casts Message-ID: <20090408123537.GI8115@axis.com> References: <1239189748-11703-1-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-2-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-3-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-4-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-5-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-6-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-7-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-8-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-9-git-send-email-jwjstone@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1239189748-11703-9-git-send-email-jwjstone@fastmail.fm> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2806 Lines: 71 On Wed, Apr 08, 2009 at 01:21:40PM +0200, Jack Stone wrote: > Remove uneeded void casts > > Signed-Off-By: Jack Stone Thanks, I'm adding the following patch to the CRIS tree: From: Jack Stone Remove uneeded void casts Signed-off-by: Jack Stone Signed-off-by: Jesper Nilsson -- cryptocop.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c index 67c61ea..beb914d 100644 --- a/arch/cris/arch-v32/drivers/cryptocop.c +++ b/arch/cris/arch-v32/drivers/cryptocop.c @@ -2455,7 +2455,8 @@ static int map_pages_to_iovec(struct iovec *iov, int iovlen, int *iovix, struct DEBUG_API(printk("map_page_to_iovec: *pageix=%d >= nopages=%d\n", *pageix, nopages)); return 0; } - iov[*iovix].iov_base = (unsigned char*)page_address(pages[*pageix]) + *pageoffset; + iov[*iovix].iov_base = + page_address(pages[*pageix]) + *pageoffset; tmplen = PAGE_SIZE - *pageoffset; if (tmplen < map_length){ (*pageoffset) = 0; @@ -2780,16 +2781,21 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig size_t tmplen = cop->tfrm_op.inlen; cop->tfrm_op.indata[0].iov_len = PAGE_SIZE - ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK); - cop->tfrm_op.indata[0].iov_base = (unsigned char*)page_address(inpages[0]) + ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK); + cop->tfrm_op.indata[0].iov_base = page_address(inpages[0]) + + ((unsigned long int)(oper.indata + prev_ix) & + ~PAGE_MASK); tmplen -= cop->tfrm_op.indata[0].iov_len; for (i = 1; itfrm_op.indata[i].iov_len = tmplen < PAGE_SIZE ? tmplen : PAGE_SIZE; - cop->tfrm_op.indata[i].iov_base = (unsigned char*)page_address(inpages[i]); + cop->tfrm_op.indata[i].iov_base = + page_address(inpages[i]); tmplen -= PAGE_SIZE; } } else { cop->tfrm_op.indata[0].iov_len = oper.inlen - prev_ix; - cop->tfrm_op.indata[0].iov_base = (unsigned char*)page_address(inpages[0]) + ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK); + cop->tfrm_op.indata[0].iov_base = page_address(inpages[0]) + + ((unsigned long int)(oper.indata + prev_ix) & + ~PAGE_MASK); } iovlen = nooutpages + 6; A small nit: If you're going to change stylistic issues please run it through checkpatch and fix them all. /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/