Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933277AbZDIOZq (ORCPT ); Thu, 9 Apr 2009 10:25:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758407AbZDIOZe (ORCPT ); Thu, 9 Apr 2009 10:25:34 -0400 Received: from mx1.emlix.com ([193.175.82.87]:53026 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755220AbZDIOZd (ORCPT ); Thu, 9 Apr 2009 10:25:33 -0400 Date: Thu, 9 Apr 2009 16:25:53 +0200 From: Johannes Weiner To: Andrew Morton Cc: Paul Mundt , os@emlix.com, dhowells@redhat.com, rmk@arm.linux.org.uk, cooloney@kernel.org, geert@linux-m68k.org, vapier.adi@gmail.com, gerg@uclinux.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -v3] flat: fix data sections alignment Message-ID: <20090409142553.GA3330@emlix.com> References: <20090310073350.GH10393@linux-sh.org> <20090402135343.d18d17a5.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090402135343.d18d17a5.akpm@linux-foundation.org> User-Agent: Mutt/1.4.2.3i Organization: emlix gmbh, Goettingen, Germany Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2026 Lines: 48 On Thu, Apr 02, 2009 at 01:53:43PM -0700, Andrew Morton wrote: > On Tue, 10 Mar 2009 16:33:50 +0900 > Paul Mundt wrote: > > > On Thu, Mar 05, 2009 at 06:00:59PM +0100, Oskar Schirmer wrote: > > > The flat loader uses an architecture's flat_stack_align() to align the > > > stack but assumes word-alignment is enough for the data sections. > > > > > > However, on the Xtensa S6000 we have registers up to 128bit width > > > which can be used from userspace and therefor need userspace stack and > > > data-section alignment of at least this size. > > > > > > This patch drops flat_stack_align() and uses the same alignment that > > > is required for slab caches, ARCH_SLAB_MINALIGN, or wordsize if it's > > > not defined by the architecture. > > > > > > It also fixes m32r which was obviously kaput, aligning an > > > uninitialized stack entry instead of the stack pointer. > > > > > > Signed-off-by: Oskar Schirmer > > > Signed-off-by: Johannes Weiner > > > Cc: David Howells > > > Cc: Russell King > > > Cc: Bryan Wu > > > Cc: Geert Uytterhoeven > > > Cc: Paul Mundt > > > Cc: Greg Ungerer > > > Cc: Mike Frysinger > > > > The updated version looks ok to me anyways, and it's certainly an > > improvement over defining the same alignment requirements all over the > > place. > > > > Acked-by: Paul Mundt > > Quite a few people expressed quite a few reservations over v2. > > Are we all OK with a v3 merge? Paul and Mike had complaints. Paul acked the last revision. Mike? We need this for upstream to compile on our configuration. Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/