Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764288AbZDISMl (ORCPT ); Thu, 9 Apr 2009 14:12:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753445AbZDISM0 (ORCPT ); Thu, 9 Apr 2009 14:12:26 -0400 Received: from rv-out-0506.google.com ([209.85.198.238]:34123 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753066AbZDISMZ convert rfc822-to-8bit (ORCPT ); Thu, 9 Apr 2009 14:12:25 -0400 MIME-Version: 1.0 In-Reply-To: <1239300433.19984.270.camel@grinch> References: <20090407180411.GA4324@beardog.cca.cpqcorp.net> <20090408061901.GN5178@kernel.dk> <1239258160.19984.217.camel@grinch> <1239296221.19984.218.camel@grinch> <1239300433.19984.270.camel@grinch> From: Kay Sievers Date: Thu, 9 Apr 2009 11:12:09 -0700 Message-ID: Subject: Re: [PATCH 1/1] cciss: resubmit export uid, model, vendor, rev to sysfs To: Andrew Patterson Cc: ens Axboe , "Mike Miller (OS Dev)" , Andrew Morton , LKML , LKML-SCSI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 35 On Thu, Apr 9, 2009 at 11:07, Andrew Patterson wrote: > On Thu, 2009-04-09 at 10:05 -0700, Kay Sievers wrote: >> The block device needs a parent, please assign the cciss bus device. >> It's the driverfs_dev in the genhd struct. >> > > This is already done in cciss_add_disk(): > >        disk->fops = &cciss_fops; >        disk->private_data = &h->drv[drv_index]; >        disk->driverfs_dev = &h->drv[drv_index].dev; > > I think my problem is I was assigning cciss_bus_type to the controller, > not the block device. I have fixed that. > # /sbin/udevadm info --attribute-walk "--path=/block/cciss!c0d0" >  looking at parent device > '/devices/pci0000:4f/0000:4f:00.0/0000:50:00.0/0000:51:04.0/0000:8b:00.0/cciss0': >    KERNELS=="cciss0" >    SUBSYSTEMS=="" This device also needs the cciss bus_type assigned, so the subsystem becomes cciss, and it also shows up in /sys/bus/cciss/devices/. Other than that, the sysfs hierarchy looks fine. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/