Return-Path: <linux-kernel-owner+w=401wt.eu-S935621AbZDISwX@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S935621AbZDISwX (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Apr 2009 14:52:23 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759643AbZDISwK
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 9 Apr 2009 14:52:10 -0400
Received: from mx2.redhat.com ([66.187.237.31]:36940 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758166AbZDISwI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Apr 2009 14:52:08 -0400
Date: Thu, 9 Apr 2009 14:52:04 -0400
From: Neil Horman <nhorman@redhat.com>
To: Jarod Wilson <jarod@redhat.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
       Herbert Xu <herbert.xu@redhat.com>
Subject: Re: [PATCH] add self-tests for rfc4309(ccm(aes))
Message-ID: <20090409185204.GA6758@hmsreliant.think-freely.org>
References: <200904091434.59639.jarod@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200904091434.59639.jarod@redhat.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1488
Lines: 36

On Thu, Apr 09, 2009 at 02:34:59PM -0400, Jarod Wilson wrote:
> Patch is against current cryptodev-2.6 tree, successfully tested via
> 'modprobe tcrypt type=45'. The number of test vectors might be a bit
> excessive, but I tried to hit a wide range of combinations of varying
> key sizes, associate data lengths, input lengths and pass/fail.
> 
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> 
>  
><snip>

> +/*
> + * rfc4309 says section 8 contains test vectors, only, it doesn't, and NIST
> + * Special Publication 800-38C's test vectors use nonce lengths our rfc4309
> + * implementation doesn't support. The following are taken from fips cavs
> + * fax files on hand at Red Hat.
> + *
> + * nb: actual key lengths are (klen - 3), the last 3 bytes are actually
> + * part of the nonce which combine w/the iv, but need to be input this way.
> + */

RFC4309 section 8 actually says the test vectors you can use are here:
http://www.ietf.org/rfc/rfc3610.txt
in RFC3610 section 8.  I don't think theres anything wrong with the vectors
your're using below, but you may want to add the vectors from 3610 just to
imrpove the testing.

Other than that, looks good.  Thanks for all the hard work!

Acked-by: Neil Horman <nhorman@tuxdriver.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/