Subject: Re: [PATCH] rtc: add x86 support for rtc-efi
From: Huang Ying <ying.huang@intel.com>
To: Brian Maly <bmaly@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
       "dannf@hp.com" <dannf@hp.com>
In-Reply-To: <49DA40B9.2060804@redhat.com>
References: <49DA40B9.2060804@redhat.com>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-UIkx++e4PBzOd+JNB2r4"
Date: Fri, 10 Apr 2009 09:08:15 +0800
Message-Id: <1239325695.6384.48.camel@yhuang-dev.sh.intel.com>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1806
Lines: 58


--=-UIkx++e4PBzOd+JNB2r4
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi, Brian,

Sorry for late.

1. Why not put these code into arch/x86/kernel/rtc.c? I think that is
more approriate.

2. It seems that you use both CMOS RTC and EFI RTC. In code path of
read_persistent_clock() and update_persistent_clock(), CMOS RTC is used
for x86_64. I think you should change that too. I have tried to do that
in http://lkml.org/lkml/2007/8/13/602.

Best Regards,
Huang Ying

On Tue, 2009-04-07 at 01:49 +0800, Brian Maly wrote:
> This patch adds support for rtc-efi (RTC Class Driver for EFI-based=20
> systems) to x86.
>=20
> This patch is based on dann frazier patch [add rtc platform driver for=20
> EFI -> http://lkml.org/lkml/2009/1/8/434], and also depends on dann's=20
> patch. Dann's patch was in the mm tree, though I think its been merged=20
> already.
>=20
> This patch has been tested and works perfectly on every x86 EFI system I=20
> could find, though all have been EL64 systems. I would appreciate any=20
> testing feedback from EL32 systems from anyone that has one and can test.
>=20
> Signed-off-by: Brian Maly <bmaly@redhat.com>
>=20
>=20
>=20
>=20

--=-UIkx++e4PBzOd+JNB2r4
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEABECAAYFAknem/wACgkQKhFGF+eHlpi/gwCfdIH3TFhph+VASUIBR/4UTlN7
5MUAoIedYHWN+iTAcfPFMA5srHEwd8bE
=eRYR
-----END PGP SIGNATURE-----

--=-UIkx++e4PBzOd+JNB2r4--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/