Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764708AbZDJLDa (ORCPT ); Fri, 10 Apr 2009 07:03:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751806AbZDJLDU (ORCPT ); Fri, 10 Apr 2009 07:03:20 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:37397 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbZDJLDT (ORCPT ); Fri, 10 Apr 2009 07:03:19 -0400 Date: Fri, 10 Apr 2009 13:03:03 +0200 From: Ingo Molnar To: Zhaolei , Pekka Enberg , Eduard - Gabriel Munteanu Cc: Steven Rostedt , Frederic Weisbecker , Tom Zanussi , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ftrace: Separate include/trace/kmemtrace.h to kmemtrace part and tracepoint part Message-ID: <20090410110303.GB21506@elte.hu> References: <49DEE68A.5040902@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49DEE68A.5040902@cn.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1693 Lines: 39 * Zhaolei wrote: > Current kmemtrace.h is used both as header file of kmemtrace and kmem's > tracepoints definition. > Tracepoints' definition file may be used by other code, and should only have > definition of tracepoint. > > We can separate include/trace/kmemtrace.h into 2 files: > include/linux/kmemtrace.h: header file for kmemtrace > include/trace/kmem.h: definition of kmem tracepoints > > Signed-off-by: Zhao Lei > --- > include/linux/kmemtrace.h | 25 +++++++++++++++++++++++++ > include/linux/slab_def.h | 2 +- > include/linux/slub_def.h | 2 +- > include/trace/{kmemtrace.h => kmem.h} | 25 +++---------------------- > init/main.c | 2 +- > kernel/trace/kmemtrace.c | 2 +- > kernel/trace/trace.h | 2 +- > mm/slab.c | 2 +- > mm/slob.c | 2 +- > mm/slub.c | 2 +- > 10 files changed, 36 insertions(+), 30 deletions(-) > create mode 100644 include/linux/kmemtrace.h > rename include/trace/{kmemtrace.h => kmem.h} (78%) Pekka, Eduard, do you agree with these two patches? Converting those tracepoints to TRACE_EVENT() is really nice. The above include file restructuring makes sense too - it separates tracepoint definition from the plugin init method. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/