Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935563AbZDJQwY (ORCPT ); Fri, 10 Apr 2009 12:52:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764012AbZDJQwO (ORCPT ); Fri, 10 Apr 2009 12:52:14 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:37112 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763215AbZDJQwO (ORCPT ); Fri, 10 Apr 2009 12:52:14 -0400 Date: Fri, 10 Apr 2009 17:50:30 +0100 From: Al Viro To: Linus Torvalds Cc: Ingo Molnar , Tejun Heo , Mike Travis , Christoph Lameter , Heiko Carstens , Martin Schwidefsky , Linux Kernel Mailing List Subject: Re: [PATCH] unbreak alpha percpu Message-ID: <20090410165030.GQ26366@ZenIV.linux.org.uk> References: <20090410151224.GM26366@ZenIV.linux.org.uk> <20090410154704.GN26366@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 24 On Fri, Apr 10, 2009 at 09:21:08AM -0700, Linus Torvalds wrote: > > Hmm. I certainly personally _much_ prefer this version. > > It looks like this actually simplifies things for S390 too (no more > simple_identifier_##var games), and generally just looks better. And > seeing that the S390 special case is no longer S390-specific is also a > good sign, imho. simple_identifier_##var has been debris from back when Ingo forced s390 to use asm-generic/percpu.h; if you look at it, you'll see that a) it hadn't worked (look at the argument list carefully) and b) get_cpu_var() has the working version anyway Less obvious part is that if it actually *would* work, we'd be screwed - unlike get_cpu_var() this sucker is called for things that are not simple variables; didn't happen for alpha, but did for s390. IOW, that's just an old piece of junk that got removed now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/