Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751730AbZDKAGv (ORCPT ); Fri, 10 Apr 2009 20:06:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751009AbZDKAGm (ORCPT ); Fri, 10 Apr 2009 20:06:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53169 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929AbZDKAGl (ORCPT ); Fri, 10 Apr 2009 20:06:41 -0400 From: "Rafael J. Wysocki" To: Linus Torvalds Subject: Re: [linux-pm] [2.6.30-rc1-git2 regressions] Hibernation broken and (minor but annoying) audio problem Date: Sat, 11 Apr 2009 02:06:32 +0200 User-Agent: KMail/1.11.2 (Linux/2.6.30-rc1-rjw; KDE/4.2.2; x86_64; ; ) Cc: linux-pm@lists.linux-foundation.org, Takashi Iwai , Arjan van de Ven , LKML , Andrew Morton , Ingo Molnar References: <200904100057.43827.rjw@sisk.pl> <200904102058.36018.rjw@sisk.pl> In-Reply-To: Organization: SUSE MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904110206.33525.rjw@suse.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2316 Lines: 65 [Sorry for having to switch the From address, my MTA has just decided to break.] On Friday 10 April 2009, Linus Torvalds wrote: > > On Fri, 10 Apr 2009, Rafael J. Wysocki wrote: > > > > I've just verified that the resume-after-hibernation issue goes away after > > reverting commit 9710794383ee5008d67f1a6613a4717bf6de47bc > > (async: remove the temporary (2.6.29) "async is off by default" code) , so it > > is async-related. > > Arjan? Clearly all the necessary fixes weren't found.. > > There _is_ a module loading problem wrt initmem - I think you found that > and we added a hack for it for the ACPI battery driver. I wonder if we're > hitting a similar issue now with module discovery: modules that use > "async_schedule()" to do their discovery asynchronously are now not > necessarily fully "done" when the module is loaded. > > And so, anything that expected the devices to be available after module > load (like they used to) would be screwed. > > IOW, maybe something like the totally untested patch appended here (that > should also allow us to make the ACPI battery code to go back to using > __init). I tested it and it worked. > As usual, I'm not using modules, so what do I know. > > > The audio issue still remains after the revert, so it is really different. > > Ok, probably something from Takashi.. This one is only reproducible in one out of three attempts on the average. I tried to bisect, but it went to nowhere. Thanks, Rafael > --- > kernel/module.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/kernel/module.c b/kernel/module.c > index 05f014e..e797812 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -2388,6 +2388,9 @@ SYSCALL_DEFINE3(init_module, void __user *, umod, > blocking_notifier_call_chain(&module_notify_list, > MODULE_STATE_LIVE, mod); > > + /* We need to finish all async code before the module init sequence is done */ > + async_synchronize_full(); > + > mutex_lock(&module_mutex); > /* Drop initial reference. */ > module_put(mod); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/