Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755378AbZDKGAi (ORCPT ); Sat, 11 Apr 2009 02:00:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752177AbZDKGA0 (ORCPT ); Sat, 11 Apr 2009 02:00:26 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:33643 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751959AbZDKGAZ (ORCPT ); Sat, 11 Apr 2009 02:00:25 -0400 Date: Fri, 10 Apr 2009 23:00:16 -0700 (PDT) Message-Id: <20090410.230016.176733137.davem@davemloft.net> To: jengelh@medozas.de Cc: paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org, mingo@elte.hu, laijs@cn.fujitsu.com, shemminger@vyatta.com, jeff.chua.linux@gmail.com, dada1@cosmosbay.com, kaber@trash.net, r000n@r000n.net, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: iptables very slow after commit 784544739a25c30637397ace5489eeb6e15d7d49 From: David Miller In-Reply-To: References: <20090411041533.GB6822@linux.vnet.ibm.com> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 23 From: Jan Engelhardt Date: Sat, 11 Apr 2009 07:14:50 +0200 (CEST) > The fact that `iptables -A` is called a hundred times means you are > doing 100 table replacements -- instead of one. And calling > synchronize_net at least a 100 times. > > "Wanna use iptables-restore?" I want to derail this line of thinking as fast as possible. This is not an acceptable response to this problem. We made something fundamentally slower by several orders of magnitude. Therefore, saying "Don't insert your firewall rules like that." is not a valid response for this regression. We really have to fix it or revert. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/