Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753888AbZDKHSd (ORCPT ); Sat, 11 Apr 2009 03:18:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752472AbZDKHSY (ORCPT ); Sat, 11 Apr 2009 03:18:24 -0400 Received: from mail-bw0-f169.google.com ([209.85.218.169]:53229 "EHLO mail-bw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbZDKHSY convert rfc822-to-8bit (ORCPT ); Sat, 11 Apr 2009 03:18:24 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=NmhMccz6bTkeGZyPy61pO2P0SjTy+KhvLsgjBEzT8vXcZfV241UA0gLVxQ/JddPRqR V3uhxo2crIBNOwh5wIFWMIUe+TS7evXBvMa0zkURQBZrMFn3BDBq+Bwl/pRcysX4Q3EA ay0tPvbp6FLoAnqGutVKactrvk92Qh2EWWIyA= MIME-Version: 1.0 In-Reply-To: <1239365545-10356-8-git-send-email-philipp.reisner@linbit.com> References: <1239365545-10356-1-git-send-email-philipp.reisner@linbit.com> <1239365545-10356-2-git-send-email-philipp.reisner@linbit.com> <1239365545-10356-3-git-send-email-philipp.reisner@linbit.com> <1239365545-10356-4-git-send-email-philipp.reisner@linbit.com> <1239365545-10356-5-git-send-email-philipp.reisner@linbit.com> <1239365545-10356-6-git-send-email-philipp.reisner@linbit.com> <1239365545-10356-7-git-send-email-philipp.reisner@linbit.com> <1239365545-10356-8-git-send-email-philipp.reisner@linbit.com> Date: Sat, 11 Apr 2009 09:18:21 +0200 Message-ID: Subject: Re: [PATCH 07/14] DRBD: internal_data_structures From: Bart Van Assche To: Philipp Reisner Cc: linux-kernel@vger.kernel.org, Jens Axboe , Greg KH , Neil Brown , James Bottomley , Andi Kleen , Sam Ravnborg , Dave Jones , Nikanth Karthikesan , Lars Marowsky-Bree , "Nicholas A. Bellinger" , Lars Ellenberg Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 26 > +static inline void drbd_kobject_uevent(struct drbd_conf *mdev) > +{ > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,10) > +#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,15) > + ? ? ? kobject_uevent(disk_to_kobj(mdev->vdisk), KOBJ_CHANGE, NULL); > +#else > + ? ? ? kobject_uevent(disk_to_kobj(mdev->vdisk), KOBJ_CHANGE); > + ? ? ? /* rhel4 / sles9 and older don't have this at all, > + ? ? ? ?* which means user space (udev) won't get events about possible changes of > + ? ? ? ?* corresponding resource + disk names after the initial drbd minor creation. > + ? ? ? ?*/ > +#endif > +#endif > +} There exist scripts which accept a kernel patch and a kernel version and remove all code that does not apply to the specified kernel version. Maybe it's a good idea to run the DRBD code through such a script before posting it for review. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/