Message-ID: <49E06C05.2060502@cn.fujitsu.com>
Date: Sat, 11 Apr 2009 18:08:05 +0800
From: Li Zefan <lizf@cn.fujitsu.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: Tom Zanussi <tzanussi@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       LKML <linux-kernel@vger.kernel.org>, paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH 0/7] tracing: bug fixes for tracing/filters
References: <49E04C22.4040608@cn.fujitsu.com> <1239442248.8793.65.camel@tropicana>
In-Reply-To: <1239442248.8793.65.camel@tropicana>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1419
Lines: 36

Tom Zanussi wrote:
> Hi,
> 
> On Sat, 2009-04-11 at 15:52 +0800, Li Zefan wrote:
>> This patchset fixes some bugs in tracing/filters. Most of the change
>> goes to the last patch, and others are small ones.
>>
> 
> At first glance, they look good and fix real problems - thanks for
> fixing them.  Re patch 7, there's been some discussion about using rcu
> for this.  See:
> 
> http://lkml.org/lkml/2009/4/5/46
> 

Hm, I didn't notice it, since I just started looking into tracing/filters
2 days ago.

>>From that discussion, it seems some non-trivial changes to rcu would be
> needed for this.  I'm playing around with a different idea now to
> hopefully avoid the need for that, or the other approach mentioned, of
> temporarily stopping tracing while removing/changing the filters.
> 
> Basically my thought is to avoid the problem by not allocating or
> destroying the preds when removing filters but instead switch out the
> pred->fns with a nop version while keeping the fields intact for awhile.
> I think that will work for removing filters, but I still need to think
> about how it would (or would not) work for replacing them.
>  

I'll keep an eye on this issue.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/