Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753110AbZDLE6e (ORCPT ); Sun, 12 Apr 2009 00:58:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752142AbZDLE6Y (ORCPT ); Sun, 12 Apr 2009 00:58:24 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:40485 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099AbZDLE6X (ORCPT ); Sun, 12 Apr 2009 00:58:23 -0400 X-Sasl-enc: aNUYp/HePj0X54xTFYQ4HqYl800r5jc5WlyVrqYERY05 1239512302 Date: Sun, 12 Apr 2009 01:58:18 -0300 From: Henrique de Moraes Holschuh To: Andrew Morton Cc: Niel Lambrechts , "linux.kernel" , linux-acpi@vger.kernel.org Subject: Re: 2.6.30-rc1 (latest git): thinkpad-acpi: cannot control brightness with hotkeys Message-ID: <20090412045818.GA8211@khazad-dum.debian.net> References: <49E10684.5090101@gmail.com> <20090411150555.8b13ed18.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090411150555.8b13ed18.akpm@linux-foundation.org> X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1565 Lines: 40 On Sat, 11 Apr 2009, Andrew Morton wrote: > > options thinkpad_acpi experimental=1 hotkey=enable,0xffffff Someday someone might be able to give me a good reason for why the hell distros like to do this sort of crap... but I don't think it will be anytime soon. > > Any ideas on how I can regain control over the brightness gas-pedal? I think what you're experiencing is some sort of breakage in ACPI video... > > WARNING: at drivers/platform/x86/thinkpad_acpi.c:2954 > > hotkey_enabledisable_warn+0x3e/0x43 [thinkpad_acpi]() > > thinkpad_acpi: hotkey enable/disable functionality has been removed from > > the driver. Hotkeys are always enabled. I will silence the warning for module parameters, thanks for the head's up. That was indeed an oversight. But it is a red-herring, it doesn't change the driver behaviour at all in this case... > > thinkpad_acpi: Standard ACPI backlight interface available, not loading > > native one. And this has always been true for any Lenovo Vista BIOS, it is not new. I really think we need to get the people dealing with ACPI video in the loop for this one. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/