Date: Sun, 12 Apr 2009 12:02:05 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Tom Zanussi <tzanussi@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>,
       Steven Rostedt <rostedt@goodmis.org>,
       LKML <linux-kernel@vger.kernel.org>, paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH 0/7] tracing: bug fixes for tracing/filters
Message-ID: <20090412100205.GA3023@elte.hu>
References: <49E04C22.4040608@cn.fujitsu.com> <1239442248.8793.65.camel@tropicana> <20090411144823.GB5977@nowhere>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090411144823.GB5977@nowhere>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1927
Lines: 54


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> On Sat, Apr 11, 2009 at 04:30:48AM -0500, Tom Zanussi wrote:
> > Hi,
> > 
> > On Sat, 2009-04-11 at 15:52 +0800, Li Zefan wrote:
> > > This patchset fixes some bugs in tracing/filters. Most of the change
> > > goes to the last patch, and others are small ones.
> > > 
> > 
> > At first glance, they look good and fix real problems - thanks for
> > fixing them.  Re patch 7, there's been some discussion about using rcu
> > for this.  See:
> > 
> > http://lkml.org/lkml/2009/4/5/46
> > 
> > >From that discussion, it seems some non-trivial changes to rcu would be
> > needed for this.  I'm playing around with a different idea now to
> > hopefully avoid the need for that, or the other approach mentioned, of
> > temporarily stopping tracing while removing/changing the filters.
> > 
> > Basically my thought is to avoid the problem by not allocating or
> > destroying the preds when removing filters but instead switch out the
> > pred->fns with a nop version while keeping the fields intact for awhile.
> > I think that will work for removing filters, but I still need to think
> > about how it would (or would not) work for replacing them.
> >  
> > Tom
> 
> 
> 
> It would be sort of reinventing rcu :-)
>
> Well, Paul proposed something recently, hmm I should 
> double check this discussion.
> 
> Anyway, the fixes from Li (other than 4 and 7 for which we 
> have comments) look very good!

Ok, i've applied 1,2,3,6 to tip/tracing/urgent (most of them 
are fixes needed for current mainline).

5 had dependency on 4 which is being discussed. 7 is being 
discussed as well, with Tom having promised a patch.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/