From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH -tip] x86: acpi/sleep.c saved_magic fix overflow
Date: Sun, 12 Apr 2009 19:25:59 +0200
User-Agent: KMail/1.11.2 (Linux/2.6.30-rc1-rjw; KDE/4.2.2; x86_64; ; )
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
       Sam Ravnborg <sam@ravnborg.org>, x86 maintainers <x86@kernel.org>,
       LKML <linux-kernel@vger.kernel.org>, josh@freedesktop.org
References: <1239385015.3169.15.camel@ht.satnam> <1239392981.5943.1.camel@localhost.localdomain> <20090410201504.GA23364@elf.ucw.cz>
In-Reply-To: <20090410201504.GA23364@elf.ucw.cz>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200904121925.59814.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1770
Lines: 49

On Friday 10 April 2009, Pavel Machek wrote:
> On Sat 2009-04-11 01:19:41, Jaswinder Singh Rajput wrote:
> > On Fri, 2009-04-10 at 21:29 +0200, Sam Ravnborg wrote:
> > > On Sat, Apr 11, 2009 at 12:46:56AM +0530, Jaswinder Singh Rajput wrote:
> > > > Sorry, I was confused by this sparse warning on 64 bit box:
> > > > 
> > > > CHECK   arch/x86/kernel/acpi/sleep.c
> > > >  arch/x86/kernel/acpi/sleep.c:107:16: warning: constant 0x123456789abcdef0 is so big it is long
> > > > 
> > > > atleast I found problem in sparse ;-)
> > > 
> > > Sparse tells you that the constant is so big it is long - correct.
> > > So rather than being implicit appending an L would make sparse happy.
> > > 
> > > So please use the constant 0x123456789abcdef0L and I think sparse is silenced.
> > > And code/functionality is the same.
> > > 
> > 
> > Yes, this fixes the sparse warning, Thanks :-)
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

OK

Ingo, are you going to take it or should I handle it?

Rafael


> > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
> > index 7c243a2..3445d0f 100644
> > --- a/arch/x86/kernel/acpi/sleep.c
> > +++ b/arch/x86/kernel/acpi/sleep.c
> > @@ -104,7 +104,7 @@ int acpi_save_state_mem(void)
> >         initial_gs = per_cpu_offset(smp_processor_id());
> >  #endif
> >         initial_code = (unsigned long)wakeup_long64;
> > -       saved_magic = 0x123456789abcdef0;
> > +       saved_magic = 0x123456789abcdef0L;
> >  #endif /* CONFIG_64BIT */
> >  
> >         return 0;
> > 
> > --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/