From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 1/1] tracing, workqueuetrace: Make workqueue tracepoints use TRACE_EVENT macro
Cc: kosaki.motohiro@jp.fujitsu.com, Zhaolei <zhaolei@cn.fujitsu.com>,
       Steven Rostedt <rostedt@goodmis.org>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       Tom Zanussi <tzanussi@gmail.com>, Ingo Molnar <mingo@elte.hu>,
       linux-kernel@vger.kernel.org
In-Reply-To: <20090413103639.6DF4.A69D9226@jp.fujitsu.com>
References: <49E28D4B.5040802@cn.fujitsu.com> <20090413103639.6DF4.A69D9226@jp.fujitsu.com>
Message-Id: <20090413122350.6DFE.A69D9226@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Mon, 13 Apr 2009 12:25:28 +0900 (JST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 781
Lines: 27

> Hi,
> 
> hehe, I also have similar patch in my local patch queue ;)
> 
> > +TRACE_EVENT(workqueue_insertion,
> > +
> > +	TP_PROTO(struct task_struct *wq_thread, struct work_struct *work),
> > +
> > +	TP_ARGS(wq_thread, work),
> > +
> > +	TP_STRUCT__entry(
> > +		__array(	char,			thread_comm,	TASK_COMM_LEN	)
> > +		__field(	pid_t,			thread_pid			)
> > +		__field(	struct work_struct *,	work				)
> > +		__field(	work_func_t,		func				)
> > +	),

and, your patch exceed 80 character in many lines.
Please use checkpatch.pl script.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/